afs commented on PR #2413: URL: https://github.com/apache/jena/pull/2413#issuecomment-2067740811
Looks good. Attached are some more tests `TestVarFinder2` for `VarFinder` directly. If you agree with my understanding, please add the file and add to `TS_Algebra`. (5 tests fail in Jena without this PR). [TestVarFinder2.java.txt](https://github.com/apache/jena/files/15049216/TestVarFinder2.java.txt) One clearing thing: `AbstractTestDynamicDataset` - the `join_*` test are still there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
