damien-veezoo commented on PR #2524: URL: https://github.com/apache/jena/pull/2524#issuecomment-2173712719
@afs thanks for reviewing! > The only thing missing is a few tests (one or two ish) in TestStoreParams (TDB1 and TDB2 versions). e.g. a new store_params_05 to check the round trip through JSON. If I'm not mistaken, `store_params_04` already tests the round trip of all store params, that's why I haven't added any new cases initially. But I have now pushed two more explicit test cases wrt. the new store param (for both TDB1 and TDB2). > On the web site, the documentation to update: add to the "per connection" section and the JSON diagram of all settings. Thanks for the pointer, I have done so and opened the following PR: https://github.com/apache/jena-site/pull/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
