afs commented on PR #2536: URL: https://github.com/apache/jena/pull/2536#issuecomment-2217296871
> [this] PR adds extra passes over the algebra tree to JoinClassifier in order to check for the operand > Could there be cases where joins are slower now than before? This PR affects the static optimization phase of query execution. It isn't in the execution loops. It should not affect performance if the new case of joining two tables isn't hit. This is tricky to determine the impact even with regression benchmarks. It is the unusual queries that possibly impacted. Users can be very creative! The `getBasis` method could be changed to deal with the `Op2` case directly which would avoid creating an iterator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
