afs commented on PR #2574:
URL: https://github.com/apache/jena/pull/2574#issuecomment-2220389628

   This PR causes problems even in a clean build.
   
   The PR is updates to the build process, not to the actual Fuseki UI cdode so 
maybe we can proceed with the release and address this issue in development in 
5.2.0-SNAPSHOT.
   
   From a local build:
   <details>
   <summary>
   Full log of the UI build stage in the arrow dropdown.
   There are Sass warnings then this test error:
   
   ```
   [INFO]  ❯ tests/unit/views/dataset/query.vue.spec.js  (1 test | 1 failed) 5ms
   [INFO]    × Query view > is created with the correct initial values
   [INFO]      → vi.useFakeTimers({ toFake: ["nextTick"] }) is not supported in 
node:child_process. Use --pool=threads if mocking nextTick is required.
   [INFO] 
   [INFO] ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯
   [INFO] 
   [INFO]  FAIL  tests/unit/views/dataset/query.vue.spec.js > Query view > is 
created with the correct initial values
   [INFO] Error: vi.useFakeTimers({ toFake: ["nextTick"] }) is not supported in 
node:child_process. Use --pool=threads if mocking nextTick is required.
   [INFO]  ❯ tests/unit/views/dataset/query.vue.spec.js:59:8
   [INFO]      57|     document.body.append(yasqeDiv)
   [INFO]      58|     // we will have to mock setTimeout and nextTick at 
least, for the …
   [INFO]      59|     vi.useFakeTimers({
   [INFO]        |        ^
   [INFO]      60|       toFake: [
   [INFO]      61|         'Date',
   [INFO] 
   [INFO] ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯
   ```
   </summary>
   
   ```
   [INFO] -------------------< org.apache.jena:jena-fuseki-ui 
>-------------------
   [INFO] Building Apache Jena - Fuseki UI 5.1.0-SNAPSHOT                   
[1/14]
   [INFO]   from pom.xml
   [INFO] --------------------------------[ jar 
]---------------------------------
   [INFO] 
   [INFO] --- enforcer:3.5.0:enforce (enforce-maven-version) @ jena-fuseki-ui 
---
   [INFO] Rule 0: org.apache.maven.enforcer.rules.version.RequireMavenVersion 
passed
   [INFO] 
   [INFO] --- enforcer:3.5.0:enforce (enforce-java-version) @ jena-fuseki-ui ---
   [INFO] Rule 0: org.apache.maven.enforcer.rules.version.RequireJavaVersion 
passed
   [INFO] 
   [INFO] --- enforcer:3.5.0:enforce (enforce) @ jena-fuseki-ui ---
   [INFO] Rule 0: 
org.apache.maven.enforcer.rules.dependency.DependencyConvergence passed
   [INFO] Rule 1: org.apache.maven.enforcer.rules.RequirePluginVersions passed
   [INFO] Rule 2: org.apache.maven.enforcer.rules.dependency.RequireReleaseDeps 
passed
   [INFO] Rule 3: org.apache.maven.enforcer.rules.version.RequireMavenVersion 
passed
   [INFO] 
   [INFO] --- remote-resources:3.2.0:process (process-resource-bundles) @ 
jena-fuseki-ui ---
   [INFO] Preparing remote bundle 
org.apache.apache.resources:apache-jar-resource-bundle:1.5
   [INFO] Copying 3 resources from 1 bundle.
   [INFO] 
   [INFO] --- frontend:1.15.0:install-node-and-yarn (install node and yarn) @ 
jena-fuseki-ui ---
   [INFO] Node v20.11.0 is already installed.
   [INFO] Yarn 1.22.17 is already installed.
   [INFO] 
   [INFO] --- frontend:1.15.0:yarn (yarn install) @ jena-fuseki-ui ---
   [INFO] Running 'yarn install --frozen-lockfile' in 
/home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui
   [INFO] yarn install v1.22.17
   [INFO] [1/4] Resolving packages...
   [INFO] success Already up-to-date.
   [INFO] Done in 0.15s.
   [INFO] 
   [INFO] --- frontend:1.15.0:yarn (yarn run build) @ jena-fuseki-ui ---
   [INFO] Running 'yarn run build' in 
/home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui
   [INFO] yarn run v1.22.17
   [INFO] $ vite build
   [INFO] vite v5.3.3 building for production...
   [INFO] transforming...
   [INFO] DEPRECATION WARNING: Sass's behavior for declarations that appear 
after nested
   [INFO] rules will be changing to match the behavior specified by CSS in an 
upcoming
   [INFO] version. To keep the existing behavior, move the declaration above 
the nested
   [INFO] rule. To opt into the new behavior, wrap the declaration in `& {}`.
   [INFO] 
   [INFO] More info: https://sass-lang.com/d/mixed-decls
   [INFO] 
   [INFO]     ┌──> node_modules/bootstrap/scss/_reboot.scss
   [INFO] 503 │     font-weight: $legend-font-weight;
   [INFO]     │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
   [INFO]     ╵
   [INFO]     ┌──> node_modules/bootstrap/scss/vendor/_rfs.scss
   [INFO] 136 │ ┌     @media (#{$rfs-mq-property-width}: #{$rfs-mq-value}) {
   [INFO] 137 │ │       @content;
   [INFO] 138 │ │     }
   [INFO]     │ └─── nested rule
   [INFO]     ╵
   [INFO]     node_modules/bootstrap/scss/_reboot.scss 503:3   @import
   [INFO]     node_modules/bootstrap/scss/bootstrap.scss 16:9  @import
   [INFO]     src/styles/index.scss 19:9                       @import
   [INFO]     src/App.vue 2:9                                  root stylesheet
   [INFO] 
   [INFO] DEPRECATION WARNING: Sass's behavior for declarations that appear 
after nested
   [INFO] rules will be changing to match the behavior specified by CSS in an 
upcoming
   [INFO] version. To keep the existing behavior, move the declaration above 
the nested
   [INFO] rule. To opt into the new behavior, wrap the declaration in `& {}`.
   [INFO] 
   [INFO] More info: https://sass-lang.com/d/mixed-decls
   [INFO] 
   [INFO]     ┌──> node_modules/bootstrap/scss/_reboot.scss
   [INFO] 504 │     line-height: inherit;
   [INFO]     │     ^^^^^^^^^^^^^^^^^^^^ declaration
   [INFO]     ╵
   [INFO]     ┌──> node_modules/bootstrap/scss/vendor/_rfs.scss
   [INFO] 136 │ ┌     @media (#{$rfs-mq-property-width}: #{$rfs-mq-value}) {
   [INFO] 137 │ │       @content;
   [INFO] 138 │ │     }
   [INFO]     │ └─── nested rule
   [INFO]     ╵
   [INFO]     node_modules/bootstrap/scss/_reboot.scss 504:3   @import
   [INFO]     node_modules/bootstrap/scss/bootstrap.scss 16:9  @import
   [INFO]     src/styles/index.scss 19:9                       @import
   [INFO]     src/App.vue 2:9                                  root stylesheet
   [INFO] 
   [INFO] DEPRECATION WARNING: Sass's behavior for declarations that appear 
after nested
   [INFO] rules will be changing to match the behavior specified by CSS in an 
upcoming
   [INFO] version. To keep the existing behavior, move the declaration above 
the nested
   [INFO] rule. To opt into the new behavior, wrap the declaration in `& {}`.
   [INFO] 
   [INFO] More info: https://sass-lang.com/d/mixed-decls
   [INFO] 
   [INFO]     ┌──> node_modules/bootstrap/scss/_type.scss
   [INFO] 38  │       font-family: $display-font-family;
   [INFO]     │       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
   [INFO]     ╵
   [INFO]     ┌──> node_modules/bootstrap/scss/vendor/_rfs.scss
   [INFO] 136 │ ┌     @media (#{$rfs-mq-property-width}: #{$rfs-mq-value}) {
   [INFO] 137 │ │       @content;
   [INFO] 138 │ │     }
   [INFO]     │ └─── nested rule
   [INFO]     ╵
   [INFO]     node_modules/bootstrap/scss/_type.scss 38:5      @import
   [INFO]     node_modules/bootstrap/scss/bootstrap.scss 17:9  @import
   [INFO]     src/styles/index.scss 19:9                       @import
   [INFO]     src/App.vue 2:9                                  root stylesheet
   [INFO] 
   [INFO] DEPRECATION WARNING: Sass's behavior for declarations that appear 
after nested
   [INFO] rules will be changing to match the behavior specified by CSS in an 
upcoming
   [INFO] version. To keep the existing behavior, move the declaration above 
the nested
   [INFO] rule. To opt into the new behavior, wrap the declaration in `& {}`.
   [INFO] 
   [INFO] More info: https://sass-lang.com/d/mixed-decls
   [INFO] 
   [INFO]     ┌──> node_modules/bootstrap/scss/_type.scss
   [INFO] 39  │       font-style: $display-font-style;
   [INFO]     │       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
   [INFO]     ╵
   [INFO]     ┌──> node_modules/bootstrap/scss/vendor/_rfs.scss
   [INFO] 136 │ ┌     @media (#{$rfs-mq-property-width}: #{$rfs-mq-value}) {
   [INFO] 137 │ │       @content;
   [INFO] 138 │ │     }
   [INFO]     │ └─── nested rule
   [INFO]     ╵
   [INFO]     node_modules/bootstrap/scss/_type.scss 39:5      @import
   [INFO]     node_modules/bootstrap/scss/bootstrap.scss 17:9  @import
   [INFO]     src/styles/index.scss 19:9                       @import
   [INFO]     src/App.vue 2:9                                  root stylesheet
   [INFO] 
   [INFO] DEPRECATION WARNING: Sass's behavior for declarations that appear 
after nested
   [INFO] rules will be changing to match the behavior specified by CSS in an 
upcoming
   [INFO] version. To keep the existing behavior, move the declaration above 
the nested
   [INFO] rule. To opt into the new behavior, wrap the declaration in `& {}`.
   [INFO] 
   [INFO] More info: https://sass-lang.com/d/mixed-decls
   [INFO] 
   [INFO]     ┌──> node_modules/bootstrap/scss/_type.scss
   [INFO] 40  │       font-weight: $display-font-weight;
   [INFO]     │       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
   [INFO]     ╵
   [INFO]     ┌──> node_modules/bootstrap/scss/vendor/_rfs.scss
   [INFO] 136 │ ┌     @media (#{$rfs-mq-property-width}: #{$rfs-mq-value}) {
   [INFO] 137 │ │       @content;
   [INFO] 138 │ │     }
   [INFO]     │ └─── nested rule
   [INFO]     ╵
   [INFO]     node_modules/bootstrap/scss/_type.scss 40:5      @import
   [INFO]     node_modules/bootstrap/scss/bootstrap.scss 17:9  @import
   [INFO]     src/styles/index.scss 19:9                       @import
   [INFO]     src/App.vue 2:9                                  root stylesheet
   [INFO] 
   [INFO] WARNING: 22 repetitive deprecation warnings omitted.
   [INFO] 
   [INFO] node_modules/@zazuko/yasqe/build/yasqe.min.js (2:313677): Use of eval 
in "node_modules/@zazuko/yasqe/build/yasqe.min.js" is strongly discouraged as 
it poses security risks and may cause issues with minification.
   [INFO] node_modules/@zazuko/yasr/build/yasr.min.js (2:367077): Use of eval 
in "node_modules/@zazuko/yasr/build/yasr.min.js" is strongly discouraged as it 
poses security risks and may cause issues with minification.
   [INFO] ✓ 254 modules transformed.
   [INFO] rendering chunks...
   [INFO] computing gzip size...
   [INFO] target/webapp/index.html                                              
  1.53 kB │ gzip:     0.86 kB
   [INFO] target/webapp/static/Edit-ez37Vkbh.css                                
  6.01 kB │ gzip:     1.57 kB
   [INFO] target/webapp/static/Query-DK4Kt2DQ.css                               
 43.76 kB │ gzip:     7.48 kB
   [INFO] target/webapp/static/index-CGEbO3-G.css                               
384.75 kB │ gzip:    52.22 kB
   [INFO] target/webapp/static/index-C-z09IKS.js                                
  1.89 kB │ gzip:     1.19 kB │ map:     1.30 kB
   [INFO] target/webapp/static/Help-CmNHmiRf.js                                 
  3.46 kB │ gzip:     1.99 kB │ map:     1.98 kB
   [INFO] target/webapp/static/Menu-BwrQSYMS.js                                 
  5.48 kB │ gzip:     2.74 kB │ map:     3.34 kB
   [INFO] target/webapp/static/Menu-BwrQSYMS.js                                 
  5.48 kB │ gzip:     2.74 kB │ map:     3.34 kB
   [INFO] target/webapp/static/Tasks-CF1a7jnq.js                                
  8.66 kB │ gzip:     4.00 kB │ map:     5.30 kB
   [INFO] (!) Some chunks are larger than 550 kB after minification. Consider:
   [INFO] target/webapp/static/current-dataset-navigation-guards-D6PAcll1.js    
 14.70 kB │ gzip:     6.49 kB │ map:     9.22 kB
   [INFO] - Using dynamic import() to code-split the application
   [INFO] target/webapp/static/NewDataset-DKyekHnJ.js                           
 14.75 kB │ gzip:     5.85 kB │ map:     8.92 kB
   [INFO] - Use build.rollupOptions.output.manualChunks to improve chunking: 
https://rollupjs.org/configuration-options/#output-manualchunks
   [INFO] target/webapp/static/ExistingDatasets-DJgwcw-V.js                     
 24.26 kB │ gzip:     8.10 kB │ map:    14.63 kB
   [INFO] - Adjust chunk size limit for this warning via 
build.chunkSizeWarningLimit.
   [INFO] target/webapp/static/Info-GyavwzQo.js                                 
 29.43 kB │ gzip:    10.13 kB │ map:    17.89 kB
   [INFO] target/webapp/static/Upload-ZYv42_6t.js                               
214.25 kB │ gzip:    61.53 kB │ map:   129.00 kB
   [INFO] target/webapp/static/bootstrap.esm-B848_XlO.js                        
522.72 kB │ gzip:   144.61 kB │ map:   330.66 kB
   [INFO] target/webapp/static/Edit-BSu19zh1.js                               
1,131.21 kB │ gzip:   348.86 kB │ map:   712.23 kB
   [INFO] target/webapp/static/index-9t_Zu7tB.js                              
3,785.23 kB │ gzip: 1,171.43 kB │ map: 2,556.53 kB
   [INFO] target/webapp/static/Query-C5U7JPu3.js                              
4,731.09 kB │ gzip: 1,257.52 kB │ map: 2,641.47 kB
   [INFO] ✓ built in 6.15s
   [INFO] Done in 6.56s.
   [INFO] 
   [INFO] --- resources:3.3.1:resources (default-resources) @ jena-fuseki-ui ---
   [INFO] skip non existing resourceDirectory 
/home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui/src/main/resources
   [INFO] Copying 3 resources from target/maven-shared-archive-resources to 
target/classes
   [INFO] 
   [INFO] --- build-helper:3.6.0:reserve-network-port (reserve-network-port) @ 
jena-fuseki-ui ---
   [INFO] Reserved port 38659 for org.apache.jena.fuseki.port
   [INFO] Reserved port 46631 for org.apache.jena.fuseki.ui.port
   [INFO] 
   [INFO] --- compiler:3.13.0:compile (default-compile) @ jena-fuseki-ui ---
   [INFO] No sources to compile
   [INFO] 
   [INFO] --- resources:3.3.1:testResources (default-testResources) @ 
jena-fuseki-ui ---
   [INFO] skip non existing resourceDirectory 
/home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui/src/test/resources
   [INFO] Copying 3 resources from target/maven-shared-archive-resources to 
target/test-classes
   [INFO] 
   [INFO] --- compiler:3.13.0:testCompile (default-testCompile) @ 
jena-fuseki-ui ---
   [INFO] No sources to compile
   [INFO] 
   [INFO] --- surefire:3.3.0:test (default-test) @ jena-fuseki-ui ---
   [INFO] 
   [INFO] --- frontend:1.15.0:yarn (yarn run test:unit) @ jena-fuseki-ui ---
   [INFO] Running 'yarn run test:unit' in 
/home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui
   [INFO] yarn run v1.22.17
   [INFO] $ vitest run --environment jsdom
   [INFO] 
   [INFO]  RUN  v2.0.1 /home/afs/ASF/jena-review/jena-fuseki2/jena-fuseki-ui
   [INFO] 
   [INFO]  ✓ tests/unit/utils/query.spec.js  (1 test) 3ms
   [INFO]  ✓ tests/unit/components/dataset/pagination.vue.spec.js  (4 tests) 
64ms
   [INFO]  ✓ tests/unit/components/serverstatus.vue.spec.js  (3 tests) 39ms
   [INFO]  ✓ tests/unit/components/dataset/tablelisting.vue.spec.js  (2 tests) 
61ms
   [INFO]  ✓ tests/unit/services/fuseki.service.spec.js  (20 tests) 31ms
   [INFO]  ❯ tests/unit/views/dataset/query.vue.spec.js  (1 test | 1 failed) 5ms
   [INFO]    × Query view > is created with the correct initial values
   [INFO]      → vi.useFakeTimers({ toFake: ["nextTick"] }) is not supported in 
node:child_process. Use --pool=threads if mocking nextTick is required.
   [INFO] 
   [INFO] ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯
   [INFO] 
   [INFO]  FAIL  tests/unit/views/dataset/query.vue.spec.js > Query view > is 
created with the correct initial values
   [INFO] Error: vi.useFakeTimers({ toFake: ["nextTick"] }) is not supported in 
node:child_process. Use --pool=threads if mocking nextTick is required.
   [INFO]  ❯ tests/unit/views/dataset/query.vue.spec.js:59:8
   [INFO]      57|     document.body.append(yasqeDiv)
   [INFO]      58|     // we will have to mock setTimeout and nextTick at 
least, for the …
   [INFO]      59|     vi.useFakeTimers({
   [INFO]        |        ^
   [INFO]      60|       toFake: [
   [INFO]      61|         'Date',
   [INFO] 
   [INFO] ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯
   [INFO] 
   [INFO]  Test Files  1 failed | 5 passed (6)
   [INFO]       Tests  1 failed | 30 passed (31)
   [INFO]    Start at  13:17:20
   [INFO]    Duration  1.26s (transform 518ms, setup 1ms, collect 1.39s, tests 
203ms, environment 1.72s, prepare 635ms)
   [INFO] 
   [INFO] error Command failed with exit code 1.info Visit 
https://yarnpkg.com/en/docs/cli/run for documentation about this command.
   [INFO] error Command failed with exit code 1.info Visit 
https://yarnpkg.com/en/docs/cli/run for documentation about this command.
   [INFO] 
------------------------------------------------------------------------
   [INFO] Reactor Summary for Apache Jena - Fuseki UI 5.1.0-SNAPSHOT:
   [INFO] 
   [INFO] Apache Jena - Fuseki UI ............................ FAILURE [  9.751 
s]
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to