Aklakan commented on code in PR #2405:
URL: https://github.com/apache/jena/pull/2405#discussion_r1750220166
##########
jena-arq/src/main/java/org/apache/jena/sparql/engine/main/OpExecutor.java:
##########
@@ -210,10 +211,19 @@ protected QueryIterator execute(OpJoin opJoin,
QueryIterator input) {
QueryIterator qIter = Join.join(left, right, execCxt);
return qIter;
}
+
+ JoinKey joinKey = null;
+ if (false) {
+ // Disabled because variable analysis may fail when custom ops are
involved.
+ Set<Var> leftVars = OpVars.visibleVars(opJoin.getLeft());
+ Set<Var> rightVars = OpVars.visibleVars(opJoin.getRight());
+ joinKey = JoinKey.create(leftVars, rightVars);
+ }
+
QueryIterator left = exec(opJoin.getLeft(), input);
QueryIterator right = exec(opJoin.getRight(), root());
- // Join key.
- QueryIterator qIter = Join.join(left, right, execCxt);
+
+ QueryIterator qIter = Join.join(joinKey, left, right, execCxt);
Review Comment:
Removed joinKey argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
