afs commented on code in PR #2782:
URL: https://github.com/apache/jena/pull/2782#discussion_r1805165438
##########
.github/workflows/maven.yml:
##########
@@ -24,10 +24,10 @@ jobs:
steps:
- uses: actions/checkout@v4
- - name: Set up JDK 17
+ - name: Set up JDK 21
Review Comment:
How about a new `maven-java21.yml`?
Jena requires java17 and I think we ought to keep `maven.yml` at that level.
##########
jena-text/pom.xml:
##########
@@ -27,8 +27,19 @@
<artifactId>jena</artifactId>
<version>5.2.0-SNAPSHOT</version>
</parent>
-
+ <profiles>
+ <!-- apache lucene emits warnings for native access and for the vector
module for java version >= 21 -->
+ <profile><id>enable-native-and-incubator-vector</id>
+ <activation>
+ <jdk>[21,22,23]</jdk>
+ </activation>
+ <properties>
+ <jena.text.test.argline>--enable-native-access=ALL-UNNAMED
--add-modules jdk.incubator.vector</jena.text.test.argline>
+ </properties>
+ </profile>
+ </profiles>
<properties>
+ <jena.text.test.argline></jena.text.test.argline>
Review Comment:
```suggestion
<jena.text.test.argline></jena.text.test.argline>
<argLine></argLine>
```
reason below
##########
jena-text/pom.xml:
##########
@@ -122,6 +133,7 @@
<includes>
<include>**/TS_*.java</include>
</includes>
+ <argLine>${jena.text.test.argline}</argLine>
Review Comment:
```suggestion
<argLine>@{argline} ${jena.text.test.argline}</argLine>
```
because mockito also needs set the `argLine` for surefire. See #2772
`@{argLine}` must be defined else it blows up.
(jena-text does not use mockito at the moment - this is guessing the future)
This whole javaagent/hardening java thing is going to be bumpy!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
