kinow commented on code in PR #2818: URL: https://github.com/apache/jena/pull/2818#discussion_r1827076165
########## CONTRIBUTING.md: ########## @@ -29,23 +27,19 @@ Documentation is kept and published via a git repository: ## Workflow -### JIRA and Github issues +### Github issues -The project uses a JIRA and also githb issues to track work. Please create one -of a JIRA issue or a github issue so that we can track a contribution. - -JIRA: - - https://issues.apache.org/jira/browse/JENA +The project github issues to track work. Please create one Review Comment: The project uses? ########## CONTRIBUTING.md: ########## @@ -29,23 +27,19 @@ Documentation is kept and published via a git repository: ## Workflow -### JIRA and Github issues +### Github issues -The project uses a JIRA and also githb issues to track work. Please create one -of a JIRA issue or a github issue so that we can track a contribution. - -JIRA: - - https://issues.apache.org/jira/browse/JENA +The project github issues to track work. Please create one Review Comment: And at the end of the line; Please create a github issue maybe? ########## CONTRIBUTING.md: ########## @@ -29,23 +27,19 @@ Documentation is kept and published via a git repository: ## Workflow -### JIRA and Github issues +### Github issues -The project uses a JIRA and also githb issues to track work. Please create one -of a JIRA issue or a github issue so that we can track a contribution. - -JIRA: - - https://issues.apache.org/jira/browse/JENA +The project github issues to track work. Please create one +of a github issue so that we can track a contribution. Github issue: https://github.com/apache/jena/issues ### Github -It is useful to create a JIRA then use the JIRA number (e.g. JENA-9999 or GH-9999) -in the Pull Request title. This activates the automated mirroring of +It is useful to create a Gihhub issue use the issue number (e.g. GH-9999) Review Comment: s/Gihhub/GitHub, and "to create a GitHub issue to use the issue number"? Or something like to use/and use/etc? ########## jena-base/src/main/java/org/apache/jena/atlas/io/BlockUTF8.java: ########## @@ -135,13 +135,32 @@ private static void toCharsBuffer(ByteBuffer bb, CharBuffer cb) { if ( (x & 0xF8) == 0xF0 ) { // Looking like 4 byte character. // 11110zzz => 4 bytes. - int ch = readMultiBytes(bb, x & 0x08, 4); + int ch = readMultiBytes(bb, x & 0x07, 4); char chars[] = Character.toChars(ch); cb.put(chars); idx += 4; continue; } + if ( (x & 0xFC) == 0xF8 ) { + // 111110zz => 5 bytes. + int ch = readMultiBytes(bb, x & 0x03, 5); + + char chars[] = Character.toChars(ch); + cb.put(chars); + idx += 5; + continue; + } + if ( (x & 0xFE) == 0xFC ) { + // Looking like 4 byte character. + // 11110zzz => 4 bytes. Review Comment: Shouldn't this one be 6 bytes? (bit late here, bit-shift-fu might be failing me :sleeping: ) ########## jena-base/src/main/java/org/apache/jena/atlas/io/BlockUTF8.java: ########## @@ -28,7 +28,7 @@ * This code is just the UTF-8 encoding rules - it does not check for legality * of the Unicode data. The standard codecs do, so do not round-trip with binary * compatibility. (Example: a single element of a surrogate pair will - * be encoded/decoded without lost.) + * be encoded/decoded without lose.) Review Comment: Or loss? (not a native, I might be wrong :+1) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
