afs commented on PR #2822: URL: https://github.com/apache/jena/pull/2822#issuecomment-2462982436
This PR is a good step forward. This PR is really two things: * The bug about manual query execution abort * A new feature - having timeouts on update. The first is as little as move one line fix :-) Having timeouts on update is good to have and the way it is done in this PR, timing out the WHERE clause of a modify `DELETE-INSERT-WHERE`, seems the best way (I'd played around with update timeout ... but stalled on that) because it protects against long-running `WHERE`. There are various operations for updates and a general timeout on an update isn't a one change in one place. Update can be several operations all in one request so there could an overall timeout (caveat the issue of various operations). The PR does impact on applications. This is not to say I think that it is bad (or good) idea but to draw out a consequence. If I've read the PR with it comes down to this one line: [pass the context to the WHERE evaluation](https://github.com/apache/jena/pull/2822/files/1db78a53978eefc808851dffe730492898f85671#diff-c57bb9dc6558a713203a51ec552b8d3f0e2ac2d76a693085664beaec44cde554R540). If a global timeout for queries is set, then that will be picked up by the update execution where it wasn't 5.2 and earlier. For Fuseki, I would guess that timeout is usually per-endpoint; it is possible to set it database or server wide as well. For an application using Jena as a library, an application wide timeout might be present and that would impact updates with this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
