afs commented on code in PR #2884:
URL: https://github.com/apache/jena/pull/2884#discussion_r1874771525


##########
jena-arq/src/test/java/org/apache/jena/sparql/algebra/TestOpAsQuery.java:
##########
@@ -482,6 +482,21 @@ public void testMinus02() {
                                                            "SELECT * { GRAPH 
?g { { ?x ?y ?z FILTER(EXISTS { ?s ?p ?o }) } ?x ?y ?z } }",
                                                               syntaxARQ); }
 
+    @Test

Review Comment:
   These EXISTS tests are about the ARQ extensions.
   
   IIRC It's not about EXISTS, it's about subquery select expressions.
   
   If that's right please use this test (insert at around L463):
   
   ```java
     @Test
     public void testSubQuery01() {
         test_roundTripQuery("SELECT ?z { SELECT ?x {  } }");
     }
   ```
   
   The outer `SELECT ?z` stops the outer `SELECT` getting removed because 
`SELECT *` is a no-op.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to