afs commented on code in PR #2925:
URL: https://github.com/apache/jena/pull/2925#discussion_r1918588438
##########
jena-arq/src/main/java/org/apache/jena/sparql/engine/iterator/QueryIterLateral.java:
##########
@@ -292,17 +295,33 @@ public Op transform(OpTable opTable) {
// By the assignment restriction, the binding only needs to be
added to each row of the table.
Table table = opTable.getTable();
// Table vars.
- List<Var> vars = new ArrayList<>(table.getVars());
- binding.vars().forEachRemaining(vars::add);
- TableN table2 = new TableN(vars);
+ List<Var> tableVars = table.getVars();
+ List<Var> vars = new ArrayList<>(tableVars);
+
+ // Track variables that appear both in the table and the binding.
+ List<Var> commonVars = new ArrayList<>();
+
+ // Index variables in a set if there are more than a few of them.
+ Collection<Var> tableVarsIndex = tableVars.size() > 4 ? new
HashSet<>(tableVars) : tableVars;
+ binding.vars().forEachRemaining(v -> {
+ if (tableVarsIndex.contains(v)) {
+ commonVars.add(v);
+ } else {
+ vars.add(v);
+ }
+ });
+
+ List<Binding> bindings = new ArrayList<>(table.size());
BindingBuilder builder = BindingFactory.builder();
table.iterator(null).forEachRemaining(row->{
- builder.reset();
- builder.addAll(row);
- builder.addAll(binding);
- table2.addBinding(builder.build());
+ if (Algebra.compatible(row, binding, commonVars.iterator())) {
Review Comment:
Sorry, I have to get Jena 5.3.0 out without this.
This issue is important and something that is, I hope, going to get more
importance in the SPARQL community.
[WG sparql-query PR 177](https://github.com/w3c/sparql-query/pull/177) at
least gets the essential machinery into the resp with the WG contribution
licnesing. A small step, but a step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
