Aklakan commented on code in PR #3047:
URL: https://github.com/apache/jena/pull/3047#discussion_r1983050888
##########
jena-tdb2/src/main/java/org/apache/jena/tdb2/solver/StageMatchTuple.java:
##########
@@ -68,6 +70,17 @@ private static Iterator<BindingNodeId> access(NodeTupleTable
nodeTupleTable, Bin
iterMatches = x.iterator();
}
+ // Add cancel check.
Review Comment:
As a separate case where timeouts get ignored (besides the hash probe table
construction), a cancel check is needed here for the following query on TDB2:
```sparql
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
SELECT ?x { ?x rdfs:label ?y . ?y rdfs:label ?z }
```
```
time curl http://localhost:3030/ds --data-urlencode 'query=PREFIX rdfs:
<http://www.w3.org/2000/01/rdf-schema#> SELECT ?x { ?x rdfs:label ?y . ?y
rdfs:label ?z }' --data-urlencode 'timeout=1'
```
Against this preloaded [TDB2 DBpedia
dataset](https://maven.aksw.org/archiva/#artifact-details-download-content~internal/tdb2.org.aksw.data.text2sparql.2025/dbpedia/1.0.0)
(~30GB)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]