Aklakan commented on code in PR #3027:
URL: https://github.com/apache/jena/pull/3027#discussion_r2083261187
##########
jena-geosparql/src/main/java/org/apache/jena/geosparql/InitGeoSPARQL.java:
##########
@@ -42,7 +42,7 @@ public static void init() {
if ( initialized )
return ;
synchronized (initLock) {
- if ( initialized ) {
+ if ( initialized || System.getProperty("jena.geosparql.skip",
"false").equalsIgnoreCase("true") ) {
Review Comment:
@LorenzBuehmann Do you recall the intention of this line?
One reason I can think of is that that jena-geosparql takes long to
initialize. IIRC due to setting up a derby database with SIS data. So any
command line jar that uses jena-geosparql takes long to load.
The loading time of own java cli tool increased from 200ms to 1.000ms just
by adding jena-geosparql.
So a future issue is to change parts of jena-geosparql's eager init to lazy
init on first use.
From this persective, the feature to disable jena-geosparql could be removed
from this PR and handled in a separate PR. I think the option would not be
needed if the init time was improved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
