rvesse commented on PR #3185: URL: https://github.com/apache/jena/pull/3185#issuecomment-2875545488
Hi @plturrell Firstly thanks for opening this PR, while contributions are always welcome large contributions of this size without any prior discussion within the community can't generally be accepted as-is. As a starting point it would be good if you could create some GitHub Issues around these modules outlining the motivation, use cases/problems solved etc so the wider community has a chance to weigh in on them, discuss other existing solutions within the project and/or wider Jena ecosystem etc. For example it sounds like the proposed `jena-rdf-delta` module may have significant overlap with the existing [`rdf-delta`](https://github.com/afs/rdf-delta) system which is a project in the wider Jena ecosystem. Often times new modules/features like these start life outside of the main Apache Jena project, and need not necessarily be integrated into the main project at all, if you go down this route please bear in mind the [ASF Trademark policy](https://www.apache.org/foundation/marks/faq/) as it pertains to software product naming. Secondly, unless these modules are deeply coupled they really should be split into two separate PRs so they can be reviewed independently of each other. When a PR is this large it's very hard to thoroughly review, the more focused you can make your individual PRs the better it is for the community to review. From a legal standpoint contributions of this size will generally require a signed [Individual Contribution License Agreement (ICLA)](https://www.apache.org/licenses/icla.pdf) from yourself, and potentially also a [Corporate Contributor License Agreement (CCLA) and Software Grant Agreement (SGA)](https://www.apache.org/licenses/contributor-agreements.html) if this work has been produced under the direction of your employer, or on employer time, who would generally hold IP rights over your work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
