Aklakan commented on code in PR #3254:
URL: https://github.com/apache/jena/pull/3254#discussion_r2148412320
##########
jena-arq/src/main/java/org/apache/jena/sparql/expr/ExprFunctionOp.java:
##########
@@ -53,11 +68,46 @@ public Expr getArg(int i) {
@Override
public Op getGraphPattern() { return op; }
- public Element getElement() { return element; }
+ public Element getElement() {
+ if (element == null) {
+ element = OpAsQuery.asElement(op);
+ }
+ return element;
+ }
@Override
public int numArgs() { return 0; }
+ @Override
+ public Expr copySubstitute(Binding binding) {
+ Op op2 = Substitute.substitute(getGraphPattern(), binding) ;
Review Comment:
Could copySubstitute in principle delegate to applyNodeTransform with a
NodeTransform based on the binding? Or are there subtle semantic difference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
