sszuev commented on PR #3347: URL: https://github.com/apache/jena/pull/3347#issuecomment-3148451134
> I took a look at removing jena-core org.apache.jena.ontology. > > There are two references outside jena-core (`schemagen` in jena-cmds, and some old code in TDB1 for old non-transactional uses cases). That's all good. > > Inside `jena-core` the situation is not too bad but not trivial. > > A few factories have ontology operations. Mostly, they need to be deprecated and point to `jena-ontapi`. > > The two big areas are the assembler subsystem and the reasoner support for owl reasoning. These look more complicated to disentangle. > > It is not that the reasoner code uses org.apache.jena.ontology (mostly, it doesn't in 'main', some in 'test') but it needs the OWL vocabulary file). > > So I'm happy to merge this PR - including the noted caveat about copied code. OK? > > Doing changes in steps is more manageable; and byJena6 we will definitely be in a better place even if the time needed to do the whole job doesn't line up. > > We can signal the intent and not be morally bound to a "Jena7" for the final step. Not many people use jena-ont-api and nobody uses assemblers yet. I think reasoner assemblers and ont-api assemblers are two different things. Currently (in this PR) ont-api assemblers use a cut down version of reasoner assemblers with `oa:` prefix, while they should use full-fetched reasoner assemblers with `ja:` prefix. The reason why I can't use ja-assemblers is that there is a conflict declarations in assembler.ttl. But, with this in mind we can take a risk and merge this pull request. Any bugs can be fixed later, and the transition to ja-resoners can be done at the time of removing the old ont-api. Another minor point: in this PR I use literals for constants (like spec), while old onr-api-assemblers use uri-resources. Not sure is this an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
