afs commented on code in PR #3184:
URL: https://github.com/apache/jena/pull/3184#discussion_r2276686641
##########
jena-arq/src/main/java/org/apache/jena/riot/system/StreamRDFOps.java:
##########
@@ -104,6 +104,11 @@ public static void sendGraphToStream(Graph graph,
StreamRDF stream, String baseU
stream.base(baseURI);
if ( prefixMap != null )
sendPrefixesToStream(prefixMap, stream) ;
+ sendGraphTriplesToStream(graph, stream);
+ }
+
+ /** Send only the triples of graph to a StreamRDF */
+ public static void sendGraphTriplesToStream(Graph graph, StreamRDF stream)
{
Review Comment:
This duplictates `sendTriplesToStream`.
Suggestion - move the triples sending code to `sendTriplesToStream`, call
`sendTriplesToStream` from `sendGraphToStream(graph, stream, base, prefixes)`
and drop `sendGraphToStream(graph, stream)`.
To me, `sendGraphToStream(graph, stream)` does imply all the graph is sent -
but the prefixes aren't which is why its `sendTriplesToStream`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
