rvesse commented on PR #3464: URL: https://github.com/apache/jena/pull/3464#issuecomment-3327393319
> > [...] the `HttpLib` changes in particular may have some unexpected side effects for downstream users. > > The main change should be only that the original sync methods now internally wait for the completion of a CompletableFuture. My feeling is that maintaining an additional non-async implementation based on the sync java.net.http API might eventually cause issues as it duplicates code that may diverge. The original test cases pass that way, but I am not sure how well tested this part is. Totally agree, and no problems with this general approach > Perhaps your previous use of the API could be added as (integration) tests? That was many years ago now and against a much older Jena version, the code in question has bit-rotted horribly. These days I use other APIs for HTTP stuff rather than leaning on Jena's APIs. This might be a non-issue, just something to highlight and make sure we communicate to users in the release this eventually lands in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
