Aklakan commented on code in PR #3441:
URL: https://github.com/apache/jena/pull/3441#discussion_r2389255394
##########
jena-rdfconnection/src/test/java/org/apache/jena/rdfconnection/TestRDFConnectionHTTP.java:
##########
@@ -1,99 +0,0 @@
-/*
Review Comment:
These tests used the `getAppProvidedAcceptHeader()` method, which I
introduced only for testing in a previous PR and which was also stated in the
javadoc ("For testing only."). In hindsight, a better solution would have been
a package private method together with the test case in the
`org.apache.jena.sparql.exec.http` package within jena-rdfconnection :/
The field and the method are now marked as deprecated - and the behavior for
`getAppProvidedAcceptHeader` has changed - so the tests no longer applied.
The value of the `appProvidedAcceptHeader` used to rely on the QueryType -
but since this wouldn't work generically for strings, this PR removed this
logic. The header is now chosen based on the exec call such as `.ask()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
