afs commented on code in PR #3603:
URL: https://github.com/apache/jena/pull/3603#discussion_r2546458566
##########
jena-arq/src/main/java/org/apache/jena/sparql/exec/QueryExecDataset.java:
##########
@@ -378,7 +378,7 @@ private static boolean isTimeoutSet(long x) {
class TimeoutCallback implements Runnable {
@Override
public void run() {
- synchronized (lockTimeout) {
+ // synchronized (lockTimeout) {
Review Comment:
But the code elsewhere has a read-set (compute) `getOrSetCancelSignal` which
sets `cancelSignal` (probably safely at the moment but its an implicit
contract) so the test here and the action should be atomic.
We could switch to `cancelSignal` is never null.
`expectedCallback` may also be changing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
