Le Sun, 31 Mar 2013 20:51:54 +0200, Dominique Michel <[email protected]> a écrit :
The optimize USE will have to wait. I get this with it: CPU version : AMD Phenom(tm) 9600 Quad-Core Processor C++ flags : -march=native -O2 -pipe -ggdb -DNDEBUG -march=k8 -mmmx -m3dnow -msse4a -mfpmath=sse -fomit-frame-pointer -ftree-loop-linear -ffinite-math-only -fno-math-errno -fno-signed-zeros -fstrength-reduce -pipe march=k8 is not really adapted for my phenom and I don' want to fight with the wscript for that. I also think a simple march="native" will do better and safer. Also, a few seconds later, the build fail at the crybaby.cpp -:::) Optimization without profiling is not something I would do in a production box anyway. > Le Sun, 31 Mar 2013 20:21:22 +0200, > Karl Lindén <[email protected]> a écrit : > > > > No, I mean with a regular build. They come after the system cflags > > > and will get privileged. According to gentoo policy, the system > > > cflags must be privileged. > > I've not seen that policy; can you provide me a link, please? > > It is at least 2 things into the devman: > http://devmanual.gentoo.org/ebuild-writing/functions/src_compile/build-environment/index.html > http://devmanual.gentoo.org/general-concepts/user-environment/index.html#not-filtering-variables > > > > > Well, -DNDEBUG should definetely be there. I think we should remove > > the -O3 and -Wall from the build system and let portage do the > > trick. I would suggest adding a useflag "optimize" and use some of > > the build systems enforced optimize flags (excluded -march, > > ofcourse) and disable them otherwise. > > I can add an optimize USE too. > > > > > The debug option to waf will trigger -O2 -g -fstack-protector-all in > > cflags, shouldn't that be stripped so that the build will only > > contain debug code compiled with the standard cflags? The user can > > add -ggdb and such in package.env if necessary. > > I agree. > > Dominique > > > > > Karl > > > > 2013/3/31 Dominique Michel <[email protected]>: > > > Le Sun, 31 Mar 2013 19:47:31 +0200, > > > Karl Lindén <[email protected]> a écrit : > > > > > >> > I guess they are in the output of ./waf .... configure. I can > > >> > do that. > > >> Yes, they are. > > >> > > >> > I am also thinking to add a custom-cflags USE because guitarix > > >> > force its own cfags. > > >> You mean if optimizations are enabled or debug enabled? Couldn't > > >> we just force disable such things and let the users CFLAGS be > > >> the one used? Are there some benefits using the enforced ones? > > > > > > No, I mean with a regular build. They come after the system cflags > > > and will get privileged. According to gentoo policy, the system > > > cflags must be privileged. > > > > > > And yes, I will add a debug USE too. And no, I am not sure if they > > > will be some benefice with them: -O3 -DNDEBUG -Wall > > > > > > -O3 and -Wall should already be in the system flags if > > > wanted/needed, but -DNDEBUG should be kept, otherwise we will get > > > debug code into the build. > > > > > > Dominique > > > > > >> > > >> Karl > > >> > > >> 2013/3/31 Dominique Michel <[email protected]>: > > >> > Le Sun, 31 Mar 2013 19:22:48 +0200, > > >> > Karl Lindén <[email protected]> a écrit : > > >> > > > >> >> I mentioned (no heavy report) it earlier today but please > > >> >> report it upstream. > > >> > > > >> > https://sourceforge.net/apps/phpbb/guitarix/viewtopic.php?f=6&t=4467 > > >> > > > >> >> We are also missing some conditional dependencies when > > >> >> python is enabled. I can add those if you don't want to > > >> >> investigate it yourself. > > >> > > > >> > I guess they are in the output of ./waf .... configure. I can > > >> > do that. > > >> > > > >> > I am also thinking to add a custom-cflags USE because guitarix > > >> > force its own cfags. > > >> > > > >> > Dominique > > >> > > > >> >> > > >> >> Karl > > >> >> > > >> >> > > >> > > > >> > > > >> > -- > > >> > "We have the heroes we deserve." > > >> > > > >> > > > >> > > >> > > > > > > > > > -- > > > "We have the heroes we deserve." > > > > > > > > > > > > -- "We have the heroes we deserve."
