Le Wed, 22 May 2013 22:14:07 +0200, Karl Lindén <[email protected]> a écrit :
> Hi, > > Great, this is needed! Thanks for your work! > > I have just done very little overlooking of your work and I have found > these issues so far: > 1. You should probably use virtual/pkgconfig not dev-util/pkgconfig > 2. The copyright header is not updated > 3. mixxx-9999-no-bzr does not apply (the .out-file is attached) > 4. A dependency on media-libs/chromaprint is missing (configure fails > for me) 5. There are trailing whitespaces in RDEPEND You can find many of those issues by just running repoman into the ebuild directory. > 6. With mixxx-9999-no-bzr patch disabled the following error occurs: > x86_64-pc-linux-gnu-g++ -o lin64_build/engine/enginefilteriir.o -c > -march=amdfam10 -O2 -fomit-frame-pointer -pipe -Wall -Wextra > -DQT_GUI_LIB -Dx86_64 -D__LINUX__ -D__UNIX__ > -DSETTINGS_PATH=\".mixxx/\" -DBPMSCHEME_FILE=\"mixxxbpmscheme.xml\" > -DSETTINGS_FILE=\"mixxx.cfg\" -DTRACK_FILE=\"mixxxtrack.xml\" > -DUNIX_SHARE_PATH=\"/usr/share/mixxx\" > -DUNIX_LIB_PATH=\"/usr/lib/mixxx\" -D__PORTAUDIO__ -DQT_TABLET_SUPPORT > -DQT_SHARED -D__SNDFILE__ -D__MAD__ -D__BULK__ -D__VINYLCONTROL__ > -DQT_NO_DEBUG_OUTPUT -DHAVE_FFTW3 -I/usr/lib64/qt4/include > -Ilin64_build -Isrc -I/usr/include/soundtouch -Ilib/replaygain > -I/usr/include/qt4 -I/usr/include/qt4/QtOpenGL > -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtSvg > -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtSql > -I/usr/include/qt4/QtScript -I/usr/include/qt4/QtXmlPatterns > -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtCore > -I/usr/lib64/qt4/include/QtCore -I/usr/lib64/qt4/include/QtGui > -I/usr/lib64/qt4/include/QtOpenGL -I/usr/lib64/qt4/include/QtXml > -I/usr/lib64/qt4/include/QtNetwork -I/usr/lib64/qt4/include/QtSql > -I/usr/lib64/qt4/include/QtScript -I/usr/lib64/qt4/include/Qt > -I/usr/include/fidlib -I/usr/include/taglib -I/usr/include/libusb-1.0 > -Ilib/xwax -Ilib/scratchlib src/engine/enginefilteriir.cpp > In file included from src/engine/enginefilterbutterworth8.cpp:23:0: > /usr/include/fidlib/fidlib.h:10:8: error: redefinition of 'struct > FidFilter' In file included from src/engine/enginefilter.h:23:0, > from src/engine/enginefilterbutterworth8.h:4, > from src/engine/enginefilterbutterworth8.cpp:20: > /usr/include/fidlib/fidlib.h:10:8: error: previous definition of > 'struct FidFilter' > src/engine/enginefilterbutterworth8.cpp: In constructor > 'EngineFilterButterworth8::EngineFilterButterworth8(filterType, int, > double, double)': > src/engine/enginefilterbutterworth8.cpp:45:89: warning: deprecated > conversion from string constant to 'char*' [-Wwrite-strings] > src/engine/enginefilterbutterworth8.cpp:50:99: warning: deprecated > conversion from string constant to 'char*' [-Wwrite-strings] > src/engine/enginefilterbutterworth8.cpp:56:89: warning: deprecated > conversion from string constant to 'char*' [-Wwrite-strings] > src/engine/enginedeck.cpp: In member function 'virtual void > EngineDeck::receiveBuffer(AudioInput, const short int*, unsigned > int)': > src/engine/enginedeck.cpp:168:26: warning: comparison between signed > and unsigned integer expressions [-Wsign-compare] > scons: *** [lin64_build/engine/enginefilterbutterworth8.o] Error 1 > scons: building terminated because of errors. > > I have not had time to do more tests and there might, thus, be > something more. Can you fix these issues (and others if there are > more)? I would be happy to submit it to the overlay when they things > are working as they should. > > Thanks in advance, > Karl Lindén > > > 2013/5/22 Alex Barker <[email protected]>: > > Hi, > > > > I have attached a large overhaul for the mixxx package and its > > dependencies including the system libs patches. > > > > dev-libs/hidapi/hidapi-0.7.0.ebuild > > dev-libs/hidapi/hidapi-0.8.0_pre20130121.ebuild > > > > Only one of the hidapi depends are needed. The 0.8 version is a > > pre-relase but it builds a lot cleaner. I have commented out the > > git portion in favor of a static download link. See bug #454948 > > for more information. > > > > media-libs/fidlib/fidlib-0.9.10-r1.ebuild > > > > Fidlib only needed a simple header control patch. See bug #449494. > > > > media-sound/mixxx/mixxx-1.11.0.ebuild > > media-sound/mixxx/mixxx-1.11.9999.ebuild > > media-sound/mixxx/mixxx-9999.ebuild > > > > The mixxx-1.11.0 ebuild is also in bugzilla (#469506) but until it > > is added I was hoping we could host them here. > > > > Thanks, > > Alex Barker -- "We have the heroes we deserve."
