Hi Raphael,

On 2007-09-18, Raphael Ritz <[EMAIL PROTECTED]> wrote:
> Hi Alex (Clark) and others,
> I'm puzzled by this change in PloneSoftwareCenter:
> http://dev.plone.org/collective/changeset/44504/PloneSoftwareCenter/trunk/content/project.py

Me too! Sorry about that.

This looks like either: 

- Me trying to make the contact field smart enough to accept either
  [EMAIL PROTECTED] or http://aclark.net (without having to type mailto: in the 
field)
  but the log message doesn't correspond to that.

-OR-

- Me testing PSC trunk against plone.org's products.zexp (as the log suggests) 
but
  the changeset makes no sense if that were the goal, unless maybe i came upon 
a traceback
  that was fixed by adding the accessor='selfCertifiedCriteria' (which seems to 
ring a faint bell).

So, I'd suggest:
Reverting to:
    validators = (('isMailto', V_SUFFICIENT), ('isURL', V_REQUIRED),), 
And leaving:
    accessor='selfCertifiedCriteria' ?

Does that make any sense? I apologize for the confusion.

Alex

> Index: PloneSoftwareCenter/trunk/content/project.py
>===================================================================
> --- PloneSoftwareCenter/trunk/content/project.py (revision 38309)
> +++ PloneSoftwareCenter/trunk/content/project.py (revision 44504)
> @@ -87,4 +87,5 @@
>           vocabulary='getSelfCertificationCriteriaVocab',
>           enforceVocabulary=1,
> +        accessor='selfCertifiedCriteria',
>           index='KeywordIndex:schema',
>           widget=MultiSelectionWidget(
> @@ -138,5 +139,6 @@
>       StringField('contactAddress',
>           required=1,
> -        validators = (('isMailto', V_SUFFICIENT), ('isURL', V_REQUIRED),),
> +        #validators = (('isMailto', V_SUFFICIENT), ('isURL', V_REQUIRED),),
> +        validators = (('isBullshit', V_SUFFICIENT), ('isHorsecrap', 
> V_REQUIRED),),
>           widget=StringWidget(
>               label="Contact address",
>
>
> Not sure what problem was "solved" here but it's obviously breaking
> the 'project' type (various tests as well as its TTP instantiation).
>
> As it seems to be related to migrating existing plone.org content
> I'm willing to not just revert it but fixing it "for real" if someone
> can explain the issue to me.
>
> Raphael


-- 
Alex Clark (http://aclark.net)


_______________________________________________
Product-Developers mailing list
Product-Developers@lists.plone.org
http://lists.plone.org/mailman/listinfo/product-developers

Reply via email to