#604: bibknowledge needs updates to better support autocomplete
---------------------------+----------------------------
Reporter: jblayloc | Owner: jblayloc
Type: defect | Status: assigned
Priority: major | Milestone:
Component: BibKnowledge | Version:
Resolution: | Keywords: review:skaplun
---------------------------+----------------------------
Changes (by jblayloc):
* status: infoneeded => assigned
Comment:
Hi Sam,
Thanks very much for reviewing the branch.
* Yes, I made sure that the API changes were to functions which weren't
used anywhere outside of bibknowledge itself, and I updated all of the
callsites. Before changing the signatures of any methods, I did a
recursive grep across the entire Invenio tree and the Inspire tree. I was
worried about projects whose directories I don't have available, which is
why I asked you about OpenAire.
* I'll split the tests as much as it makes sense to do. It turns out that
even the unit tests make certain assumptions about the shape of the
database, so it's not obvious to me that they count as unit tests in sense
usually meant in Invenio. But I'll go ahead and split the files along
what seem like logical lines.
* Re: 'jquery'->'json': Great! I need to refactor the json formatting
parts out of bibknowledgeadmin.kb_export() so that they can be used in a
bfe anyway, so I'll do this as part of that (but don't worry, the exterior
profile of kb_export() won't change.)
* Re: 'closes' tag: oops. I always forget about those. Thanks!
Joe
--
Ticket URL: <http://invenio-software.org/ticket/604#comment:6>
Invenio <http://invenio-software.org>
