This is an automated notification sent by LCG Savannah.
It relates to:
bugs #61100, project CDS Invenio
==============================================================================
LATEST MODIFICATIONS of bugs #61100:
==============================================================================
Follow-up Comment #4, bug #61100 (project cdsware):
Thanks, cherry-picked, amended (see below), and committed
(415d9ad5f9c38170266ff53a285f334d90ef708a). Please check and
delete your personal branch.
Amendments done:
- Fixed regexp _re_find_or_fin_at_start because it was mis-catching
query terms like `findme'.
- Removed introduced but unused variable _re_fin_at_start.
- Removed trailing whitespace.
- Updated commit log, e.g. to distinguish between Savannah task number
and bug number.
(FYI, I'm usually fixing small issues like that during cherry-picking,
and committing them in your name, if issues are clear and minor. I
hope that is fine with you. This is to avoid a merge commit, to keep
the current linear repo history clean. When we shall introduce the
multi-branch setup, after the next release, the merge integration mode
would be favoured instead of the cherry-pick integration mode, but
this will come later.)
==============================================================================
OVERVIEW of bugs #61100:
==============================================================================
URL:
<http://savannah.cern.ch/bugs/?61100>
Summary: SPIRES syntax is not fully supported
Project: CDS Invenio
Submitted by: benoitthiell
Submitted on: 2010-01-05 19:23
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Item Group: None
Status: Fixed
Privacy: Public
Assigned to: jblayloc
Originator Email:
Open/Closed: Closed
Discussion Lock: Any
_______________________________________________________
The SPIRES help page
(http://www.slac.stanford.edu/spires/hep/help/index.shtml) lists 'fin' as a
supported abbreviation for 'find'. However it does not seem to be supported
in Invenio as the SPIRES syntax is not detected.
This works: "find t ads".
This doesn't: "fin t ads".
_______________________________________________________
Follow-up Comments:
-------------------------------------------------------
List-Post: [email protected]
Date: 2010-02-17 14:10 By: Tibor Simko <simko>
Thanks, cherry-picked, amended (see below), and committed
(415d9ad5f9c38170266ff53a285f334d90ef708a). Please check and
delete your personal branch.
Amendments done:
- Fixed regexp _re_find_or_fin_at_start because it was mis-catching
query terms like `findme'.
- Removed introduced but unused variable _re_fin_at_start.
- Removed trailing whitespace.
- Updated commit log, e.g. to distinguish between Savannah task number
and bug number.
(FYI, I'm usually fixing small issues like that during cherry-picking,
and committing them in your name, if issues are clear and minor. I
hope that is fine with you. This is to avoid a merge commit, to keep
the current linear repo history clean. When we shall introduce the
multi-branch setup, after the next release, the merge integration mode
would be favoured instead of the cherry-pick integration mode, but
this will come later.)
-------------------------------------------------------
List-Post: [email protected]
Date: 2010-02-17 03:09 By: Joe Blaylock <jblayloc>
I decided that I could do this before moving around the other tests - I'll
ask to have this in master and then move everything around together.
I added the test and squashed things together. This in in my branch
'websearch-find-fin' commit 264a3791adc6f2f2f9a4c8c46d5d569c7948cb9c.
-------------------------------------------------------
List-Post: [email protected]
Date: 2010-02-17 01:48 By: Joe Blaylock <jblayloc>
This is fixed in commit 000dd0928be5ad548abdd70a694fa868b6d5de25 on my branch
'websearch-find-fin'. I'm not ready to mark this closed yet, however, because
it needs tests.
So this is blocking on the testing fixups referred to elsewhere.
-------------------------------------------------------
List-Post: [email protected]
Date: 2010-02-17 00:02 By: Joe Blaylock <jblayloc>
cds-invenio/modules/websearch/lib$ grep find *.py | grep -v "find_" | grep -v
"\.find(" | grep -v _tests.py |grep -v finditer
search_engine_query_parser.py: self._re_search_term_pattern_match =
re.compile(r'\b(?P<combine_operator>find|and|or|not)\s+(?P<search_term>title:|keyword:)(?P<search_content>.*?\b)(?=
and | or | not |$)', re.IGNORECASE)
search_engine_query_parser.py: if query.lower().startswith("find "):
search_engine_query_parser.py: if combine_operator.lower() ==
'find':
search_engine_query_parser.py: result = 'find ' +
search_term + word
search_engine_query_parser.py: regex_string =
r'\b((?<=find)|(?<=and)|(?<=or)|(?<=not))\s*' + old_keyword
websearch_external_collections_parser.py: def __init__(self,
host="www.slac.stanford.edu", path="spires/find/hep/"):
websearch_external_collections_searcher.py: self.search_url =
"http://www.slac.stanford.edu/spires/find/hep/?rawcmd=find+";
websearch_external_collections_searcher.py: self.search_url =
"http://www.slac.stanford.edu/spires/find/books/?rawcmd=find+";
websearch_external_collections_searcher.py: self.base_url =
"http://www.slac.stanford.edu/spires/find/tserials/";
websearch_external_collections_searcher.py: self.search_url =
"http://www.slac.stanford.edu/spires/find/tserials/?rawcmd=find+";
_______________________________________________________
Carbon-Copy List:
CC Address | Comment
------------------------------------+-----------------------------
1576 | -COM-
5878 | -COM-
6204 | -SUB-
==============================================================================
This item URL is:
<http://savannah.cern.ch/bugs/?61100>
_______________________________________________
Message sent via/by LCG Savannah
http://savannah.cern.ch/
