I think it’s your call to release 1.0, so if you feel it’s right then go ahead :)
I do think we should make sure we do our best not to have inconsistencies or possible breaking changes, so Julien’s PR about the config consistency should probably be included. On Fri 24. Apr 2020 at 01:20, Julien Pivotto <roidelapl...@inuits.eu> wrote: > On 24 Apr 01:14, Bjoern Rabenstein wrote: > > On 23.04.20 13:40, Richard Hartmann wrote: > > > > > > Should the maintainers (Ben & Fish) be allowed to release without > > > waiting for the audit to finish? > > > > If that's their wish, yes, sure. > > > > Under the described circumstances, I don't see a reason to block them. > > > I would however draw the attention to the fact that the current config is > far from what Prometheus offers (regarding config key names). > > I have filled in https://github.com/prometheus/node_exporter/pull/1685 > to make it look similar to what we have in the prometheus server. > > > > > -- > > Björn Rabenstein > > [PGP-ID] 0x851C3DA17D748D03 > > [email] bjo...@rabenste.in > > > > -- > > You received this message because you are subscribed to the Google > Groups "Prometheus Developers" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to prometheus-developers+unsubscr...@googlegroups.com. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/prometheus-developers/20200423231459.GJ2315%40jahnn > . > > -- > (o- Julien Pivotto > //\ Open-Source Consultant > V_/_ Inuits - https://www.inuits.eu > > -- > You received this message because you are subscribed to the Google Groups > "Prometheus Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to prometheus-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/prometheus-developers/20200423232018.GA1315860%40oxygen > . > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAOs1Umw2OcfqCfmVbLtZCtEPn-m9aJ5Mifae8%2ByMmQM7s29%2BmA%40mail.gmail.com.
