I think having Gitpod as a CI check wouldn't just be useful for manual testing, but it's nice for a reviewer to be able to jump into a ready-to-go checked-out-and-built dev environment based off a PR branch, with editor and code intelligence that allows you to properly jump around and understand the PR code, etc., without having to check out the PR branch locally. For people who want it, they can even comment on changes directly from Gitpod (https://www.gitpod.io/docs/code-reviews/).
If at any point Gitpod stops working / we don't like it anymore, we can just remove it. I don't think we would ever hit the 50h limit, and even then that's probably negotiable. On Sun, Jul 26, 2020 at 6:19 PM Julien Pivotto <roidelapl...@prometheus.io> wrote: > Hello, > > While getting new contributors is fundamental for any open source > projects, I would be on the side to explore other possibilities than this > one. Let me explain my concerns. > > First of all, that is an extra tool. I am not a fan on adding extra tools > on top of GitHub, like gerrithub or other review platforms. Especially > tools that would not be used by us as a team. > > When we redirect our users to a third party platform, we are 'endorsing' > then in some way. I have not investigated the specifics of the proposed > platforms, but we would have to review the tos of that platform and look if > that is in line with our expectations. > > We have got in the past first time contributors starting features, > implementations, and then vanish before the code is in a mergeable state. > We should find a compromise so that such a platform to embark more people > does not lead us in that direction more often. > > I also note that the scope is unclear. Is that for the react app? For > TSDB? It would be strange to have a solution that would only work for one > of them, e.g. react, because otherwise if someone comes with a solution for > TSDB, we would end up with two solutions. > > I do note that the open source version is limited to 50h/month; and that > the application itself has < 1000 users according to GitHub. > > Le dim. 26 juil. 2020 à 14:42, Julius Volz <julius.v...@gmail.com> a > écrit : > >> +CC Sven from Gitpod >> >> On Sun, Jul 26, 2020 at 2:40 PM Julius Volz <julius.v...@gmail.com> >> wrote: >> >>> Hi, >>> >>> I got to know the people from Gitpod.io (https://www.gitpod.io/), and >>> when I learned about their capability to not only use Gitpod as a regular >>> online web-based dev environment, but to create ad-hoc environments based >>> off PR branches as CI checks, I thought it would be a really neat thing to >>> have that for Prometheus (it's free for OSS). It would also be generally >>> great to give people a web-based container that has Prometheus pre-built >>> and the dev environment ready and setup for working on the code. A proposed >>> PR for the latter is here (AFAIK this doesn't do the CI integration yet, >>> but that would be great too, then you can explore with the binary + code at >>> a PR branch online, without checking it out locally): >>> https://github.com/prometheus/prometheus/pull/7673 >>> >>> What do people think? >>> >>> Cheers, >>> Julius >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Prometheus Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to prometheus-developers+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6YoygV%3Dz3hDjb06DeK8E9ikT7RRe5tswnvvw_d%2Bv%2BOfnh2w%40mail.gmail.com >> <https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6YoygV%3Dz3hDjb06DeK8E9ikT7RRe5tswnvvw_d%2Bv%2BOfnh2w%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6YoyWrc7dG4dx1h5COiU9JYv6dye69Pbs%2B59nReH6Y8%2B_qw%40mail.gmail.com.
