On Tue, 4 May 2021 at 15:36, Julien Pivotto <roidelapl...@prometheus.io> wrote: > > count_values("le,g.2") > > I would suggest using an optional argument instead: > > count_values("le", "%.2f")
There are a couple of issues with that approach. we would either have to modify the evaluator.aggregation() function to accept multiple params, or split COUNT_VALUES out into its own path. Also, using a standalone % string might mislead people into thinking a full Printf format string was an option (there are practical reasons why accepting an arbitrary printf string would have problems). count_values ("le%2g",...) feels less prone to that misunderstanding. -- Tristan Colgate-McFarlane ---- "You can get all your daily vitamins from 52 pints of guiness, and a glass of milk" -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAPGZSGKMzaaUyVxY-Ssi4iOSYV_EN%2Bb%3DX-GNvbJMPRaxGXocyg%40mail.gmail.com.