On 06 Dec 17:54, Bjoern Rabenstein wrote: > On 28.11.22 11:29, Julien Pivotto wrote: > > > > However, I have crafted a pull request that changes that consensus and > > makes HTTP headers configurable in the common HTTP client, with some > > reserved headers. > > For findability: https://github.com/prometheus/common/pull/416 > > > What does the community & team members think about this? > > Personally, I have no strong opinion on this. > > However, since we apparently created a consensus previously to not do > this, could you perhaps remind everyone what the reasoning behind that > consensus was?
https://github.com/prometheus/prometheus/issues/1724 Quoting Brian in 2016: > The question here is how complex do we want to allow scraping protocol > to be, and how complex a knot are we willing to let users tie themselves > in via the core configuration? Are we okay with making it easy for a > scrape not to be quickly testable via a browser? At some point we have > to tell users to use a proxy server to handle the more obscure use > cases, rather than drawing their complexity into Prometheus. > > As far as I'm aware the use case here relates to a custom auth solution > with a non-recommended network setup. It's not unlikely that the next > request in this vein would be to make these relabelable, and as this is > an auth-related request, per discussion on #1176 we're not going to do > that. I think we'd need a stronger use case to justify adding this > complexity. I do think that Brian's comments on authorization and security are still valid, and I don't plan to add headers support to relabeling - such as I don't plan to add relabeling for basic auth and other autorisation methods. -- Julien Pivotto @roidelapluie -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/Y4%2B%2B5ZTO/3wDW7X8%40nixos.
