Hi Matthew, Thank you for looking into it and providing a better solution!
Your patch to our module looks good. We'll get it tested and merged, and get rid of the prosody patch :) Regards, Boris On Thu, Feb 16, 2023 at 12:24 PM Matthew Wild <[email protected]> wrote: > > Hi Boris, > > On Wed, 15 Feb 2023 at 23:19, Boris Grozev <[email protected]> wrote: > > I'm attaching an updated version, the previous has a typo that breaks > > it and an unnecessary line. > > Thanks! After reviewing it today, I decided not to merge it. The > changes are a bit more invasive than I'm comfortale with. For example, > util.session should generally be unaware of HTTP as a concept. I > considered introducing the idea of a generic "real IP" (which at its > simplest would be a variable rename in your patch!). However that's > something we might tackle as part of a more generic API for proxied > connections in the future - we have some modules that already handle > haproxy's PROXY protocol, and we would like to make these more neatly > integrated with Prosody's core. > > The good news is that I have an alternative solution for your problem. > I committed a trivial new API to net.http.server: > https://hg.prosody.im/0.12/rev/3a6dae39c70e > > I've made a PR to the Jitsi module with the changes that I think would > need to be made to take advantage of this API: > https://github.com/jitsi/infra-configuration/pull/55 > > Hope this helps! > > Regards, > Matthew > > -- > You received this message because you are subscribed to the Google Groups > "prosody-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/prosody-dev/CAJt9-x4T%2BU-NpWBj3_X4MO4Vv95QEiNMArwAW%3DUoyUH6ZUKYrQ%40mail.gmail.com. -- You received this message because you are subscribed to the Google Groups "prosody-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prosody-dev/CAFCpYuy688RwqbwTxYP7XHU7A4LN%3DdmXDOdzNdBeZjzwkYs1mA%40mail.gmail.com.
