Hi,

On Mon, 20 Mar 2023 at 22:47, vkvo2000 via prosody-dev
<[email protected]> wrote:
>
> Following the behavior in auth_internal_hashed, the account will be created 
> and
> disabled, instead of returning an error telling password being nil when 
> calling
> saslprep().

Thanks for the patch! I've merged it with a couple of tweaks (if you
pull and evolve, it should fix any conflicts between your patch and my
changes).

- I added a reference in the commit message to the specific commit
where mod_admin_shell's behaviour changed (e.g. so it's easy to
discover exacly when the bug was introduced)
- I noted in the message that mod_auth_internal_plain doesn't actually
fully support "disabled" accounts currently
- I fixed some minor style things - we generally only use semicolons
as separators when they are at the end of a line

Congrats on your first merged contribution :)

Regards,
Matthew

-- 
You received this message because you are subscribed to the Google Groups 
"prosody-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prosody-dev/CAJt9-x7Gr7SUzpfGODv6B-N-b5YmzhHr%2B7bSyPRjrANT5-NCRA%40mail.gmail.com.

Reply via email to