Hey, yep that's better! Thanks for the very quick merge :)
I haven't tested the new patch yet, but it looks good! Will do tests later :) Linus Am 7. Juni 2024 17:29:34 MESZ schrieb Matthew Wild <mwi...@gmail.com>: >Hi, > >On Fri, 7 Jun 2024 at 16:18, Linus Jahn <l...@kaidan.im> wrote: >> I tried to test my FAST implementation in QXmpp >> (https://github.com/qxmpp-project/qxmpp/pull/630) >> and noticed that HT-SHA-256-NONE (without channel binding) does always fail >> and I managed to fix >> it, so here's the patch. :) > >Thanks for the report and patch! I've actually pushed a slightly >different change that should fix the issue, and generally improve the >code (it was going to be checking cb_name 3 times in a row after your >patch). Now we just check it once: >https://hg.prosody.im/prosody-modules/rev/e67fc7b66c13 > >I haven't tested, so hopefully it still works and fixes your issue :) > >Regards, >Matthew > >PS. Excited to see FAST support in QXmpp! > >-- >You received this message because you are subscribed to the Google Groups >"prosody-dev" group. >To unsubscribe from this group and stop receiving emails from it, send an >email to prosody-dev+unsubscr...@googlegroups.com. >To view this discussion on the web visit >https://groups.google.com/d/msgid/prosody-dev/CAJt9-x76kPqBojh_XzwcqmbSYm8V4XXd2kMDXeez%3Dzo8His8dA%40mail.gmail.com. -- You received this message because you are subscribed to the Google Groups "prosody-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to prosody-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/prosody-dev/83719F3C-EAB5-4433-87F0-5F8F5B46EE35%40kaidan.im.
