On Thu, Apr 17, 2025 at 09:05:20PM -0400, 'Goot the ticklegoblin!' via
prosody-dev wrote:
Attached is a patch for issue #1924, fixing a compliance issue with RFC 6121.
Thanks for the patch.
While following the instructions on the website for creating patches,
`make test` gave the following output:
GNUmakefile:2: config.unix: No such file or directory
make: *** No rule to make target 'config.unix'. Stop.
This happens because `./configure && make` needs to be run first.
However, that runs the unit tests, which do not cover roster
interactions.
Rather we would want to have scansionน and run `make integration-test`.
The tests it runs are in `spec/scansion/`, e.g. this one would be
relevant to update, or base a new one on:
https://hg.prosody.im/trunk/file/tip/spec/scansion/basic_roster.scs
However, considering the trivial nature of the change, it's unlikely that it
wouldn't pass any automated test.
Attempting to adjust our tests to check for this, I noticed that this
only covers roster pushes, not roster fetches, which are implemented in
mod_roster.
--
Zash
น https://matthewwild.co.uk/projects/scansion/
--
You received this message because you are subscribed to the Google Groups
"prosody-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/prosody-dev/aBjTjE-q3deKcsNv%40diploria.zash.se.
