On Tue, Apr 21, 2009 at 12:59 PM, Kenton Varda <ken...@google.com> wrote:

> Petar, can you review this?


The patch looks good.
I'll submit it in SVN after we receive the CLA.


>
> Christian:  Thanks, I don't think we had any idea this was happening (doh).
>  Can you sign the CLA if you haven't already?
>
> http://code.google.com/legal/individual-cla-v1.0.html -- If you own the
> copyright on your patch.
> http://code.google.com/legal/corporate-cla-v1.0.html -- If your employer
> does.
>
> On Sun, Apr 19, 2009 at 1:43 PM, Christian M <christian...@gmail.com>wrote:
>
>> Hi all,
>>
>> Current implementation of OutputStream in python has significant
>> performance problems on windows due realloc for every append in
>> array.fromstring. SerializeToString on a 600k buffer could take
>> minutes on windows. The problem does not occur on Linux/OSX for our
>> test-cases.
>> Patch with OutputStream implemented with cStringIO attached.
>>
>> Regards,
>> Christian
>>
>> >>
>>
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To post to this group, send email to protobuf@googlegroups.com
To unsubscribe from this group, send email to 
protobuf+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to