If the tests pass, it should be good to go. Please do submit patches. On Wed, Jun 24, 2009 at 2:09 PM, vikram <patilvik...@gmail.com> wrote:
> > I was finally able to compile it correctly and evaluate its > correctness using tests. > > Kenton, > > Is there anything else I need to evaluate before using compiler > and binaries. I can provide patch now if its needed. > I am also going to try same procedure on AIX too . Is there any other > precautions I needed to take before compiling on AIX? > If it goes through without problem, I can provide patch which can > include changes for both Solaris and AIX . > > > Vikram > > On Jun 24, 1:40 pm, vikram <patilvik...@gmail.com> wrote: > > @Monty > > I followed your steps but make check still fails with following > > errors > > make check > > Making check in . > > make check-local > > Making lib/libgtest.a lib/libgtest_main.a in gtest > > `lib/libgtest.la' is up to date. > > `lib/libgtest_main.la' is up to date. > > Making check in src > > make check-am > > make protobuf-test protobuf-lazy-descriptor-test zcgzip zcgunzip > > source='google/protobuf/compiler/cpp/cpp_unittest.cc' > > object='protobuf_test-cpp_unittest.o' libtool=no \ > > DEPDIR=.deps depmode=none /bin/bash ../depcomp \ > > CC -DHAVE_CONFIG_H -I. -I.. -I../gtest/include -I../gtest/ > > include -D_REENTRANT -g -DNDEBUG -c -o protobuf_test-cpp_unittest.o > > `test -f 'google/protobuf/compiler/cpp/cpp_unittest.cc' || echo > > './'`google/protobuf/compiler/cpp/cpp_unittest.cc > > "./google/protobuf/descriptor.h", line 324: Warning: Identifier > > expected instead of "}". > > "./google/protobuf/descriptor.h", line 343: Warning: Identifier > > expected instead of "}". > > "./google/protobuf/descriptor.h", line 354: Warning: Identifier > > expected instead of "}". > > "./google/protobuf/io/tokenizer.h", line 107: Warning: Identifier > > expected instead of "}". > > "google/protobuf/compiler/cpp/cpp_unittest.cc", line 120: Warning: A > > non-POD object of type "std::string " passed as a variable argument to > > function "testing::internal::IsNullLiteralHelper(...)". > > "google/protobuf/compiler/cpp/cpp_unittest.cc", line 442: Error: > > TestAllTypes is not defined. > > "google/protobuf/compiler/cpp/cpp_unittest.cc", line 457: Error: > > TestPackedTypes is not defined. > > "google/protobuf/compiler/cpp/cpp_unittest.cc", line 475: Error: > > TestAllTypes is not defined. > > "google/protobuf/compiler/cpp/cpp_unittest.cc", line 494: Error: > > TestPackedTypes is not defined. > > 4 Error(s) and 5 Warning(s) detected. > > *** Error code 4 > > make: Fatal error: Command failed for target `protobuf_test- > > cpp_unittest.o' > > Current working directory /work/vpatil/protobuf-2.1.0/src > > *** Error code 1 > > make: Fatal error: Command failed for target `check-am' > > Current working directory /work/vpatil/protobuf-2.1.0/src > > *** Error code 1 > > make: Fatal error: Command failed for target `check' > > Current working directory /work/vpatil/protobuf-2.1.0/src > > *** Error code 1 > > The following command caused the error: > > failcom='exit 1'; \ > > for f in x $MAKEFLAGS; do \ > > case $f in \ > > *=* | --[!k]*);; \ > > *k*) failcom='fail=yes';; \ > > esac; \ > > done; \ > > dot_seen=no; \ > > target=`echo check-recursive | sed s/-recursive//`; \ > > list='. src'; for subdir in $list; do \ > > echo "Making $target in $subdir"; \ > > if test "$subdir" = "."; then \ > > dot_seen=yes; \ > > local_target="$target-am"; \ > > else \ > > local_target="$target"; \ > > fi; \ > > (cd $subdir && make $local_target) \ > > || eval $failcom; \ > > done; \ > > if test "$dot_seen" = "no"; then \ > > make "$target-am" || exit 1; \ > > fi; test -z "$fail" > > make: Fatal error: Command failed for target `check-recursive' > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to protobuf@googlegroups.com To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/protobuf?hl=en -~----------~----~----~----~------~----~------~--~---
