Yeah, the test only compares "default compression" to "no compression" -- even with the small message, default compression manages to compress a little bit. Committed as rev 170.
On Fri, Jul 31, 2009 at 5:08 PM, <peter.k...@gmail.com> wrote: > On 2009/07/31 23:56:40, kenton wrote: > > This looks great, Kenton. Thanks for cleaning it up! The tests look > pretty decent as well. With such a small golden message you're probably > not going to see any difference between the different compression > levels, and it is just passed through to zlib so there's probably no > point in testing it here. > > > > http://codereview.appspot.com/96211 > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to protobuf@googlegroups.com To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/protobuf?hl=en -~----------~----~----~----~------~----~------~--~---
