Hi Nadav, On Tue, May 5, 2020 at 5:25 PM Nadav Samet <thesa...@gmail.com> wrote:
> Hi Josh, thanks for the heads up on the upcoming change needed by source > code generators. > > At first sight, the implementation detail around > synthetic/real oneofs seems like a clever hack to avoid breaking some code > that uses reflection, but the consequence would be that: > 1. some code that does reflection would still break and need to be > updated, for example if the reflection translates from a representation > that depends on the oneof's name. > What representations do you mean? In general it is not expected that oneof names are exposed in wire formats. Authors of .proto files are free to change them at will without breaking the wire. > 2. the synthetic/real oneofs distinction is going to remain with us in the > foreseeable future and we'll have to keep it in mind when we write > generators and reflection code: we will always need to think which list of > oneofs is the appropriate one to iterate on. > Reflection code should not generally have to think about the difference between real and synthetic oneofs. The main exception is if you are generating an API or documentation that is consumed by users. But I expect this is a small minority of all code using reflection. Can you give an example of some of the code that would be affected? > -Nadav > > > On Tue, May 5, 2020 at 2:13 PM 'Josh Haberman' via Protocol Buffers < > protobuf@googlegroups.com> wrote: > >> I have released Protobuf v3.12.0-rc1 to GitHub and the per-language >> repositories (NuGet, npm, RubyGems, etc). >> >> https://github.com/protocolbuffers/protobuf/releases/tag/v3.12.0-rc1 >> >> Please try it out and let us know if you have any issues. The full 3.12.0 >> release should follow within a week or so. >> >> If you own a code generator, please especially take note of the changelog >> in the link above. A new experimental feature (proto3 presence) require all >> code generators to update. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Protocol Buffers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to protobuf+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/protobuf/41207f02-8d37-42e4-a148-6580c90ab48a%40googlegroups.com >> <https://groups.google.com/d/msgid/protobuf/41207f02-8d37-42e4-a148-6580c90ab48a%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > > > -- > -Nadav > -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/protobuf/CAFFe09ikXoeRbxVoK23L660dcq6PO3zQqXsp3GgPEmsTdKez1w%40mail.gmail.com.
