[x] Ship it. Reviewed the C code change with Rafi. Rajith
On Mon, Nov 5, 2012 at 7:29 AM, Rob Godfrey <rob.j.godf...@gmail.com> wrote: > [X] Ship it! (Release RC4 as 0.2) > > Tested java and reviewed C change. > > -- Rob > > On 5 November 2012 13:19, Rafael Schloming <r...@alum.mit.edu> wrote: > >> Posted here: http://people.apache.org/~rhs/qpid-proton-0.2rc4/ >> >> [ ] Ship it! (Release RC4 as 0.2) >> [ ] No (We need another RC because...) >> >> The only difference between RC3 and RC4 for proton-c is a one line change >> in engine.c that ensures that pn_transport_output will not fail to produce >> output under particular conditions despite there being output to produce. >> There was also a public accessor added in proton-j. Both of these are very >> small and sufficiently isolated changes that they shouldn't impact any >> testing that has been done on RC3. I've attached the total diff in case >> anyone wants to check it out. I'm hoping we can still get enough votes to >> do a release tonight so please have a look and give it your +1 if it checks >> out. >> >> --Rafael >>
