[ 
https://issues.apache.org/jira/browse/PROTON-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782072#comment-13782072
 ] 

Darryl L. Pierce commented on PROTON-342:
-----------------------------------------

Looking into this more, the pkg-config file (libqpid-proton.pc) seems to be 
setting its values properly. There was a separate bug (PROTON-412) that fixed 
issues with that file, where the paths were being misconfigured.

The only issue that'll come up is that the paths within it are based on the 
environment as described to CMake prior to the build. Using DESTDIR isn't meant 
to update the paths in that file but is used for things like building for a 
package distribution; i.e., you wouldn't use it to actually install onto your 
system.

The dynamic languages are behaving as expected, as they will install to 
directories as specified by the dynamic languages themselves.

Should we then close this issue?

> installing into custom location doesn't work nicely (and is not properly 
> documented)
> ------------------------------------------------------------------------------------
>
>                 Key: PROTON-342
>                 URL: https://issues.apache.org/jira/browse/PROTON-342
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.4
>            Reporter: Gordon Sim
>            Assignee: Darryl L. Pierce
>
> The README suggests setting -DCMAKE_INSTALL_PREFIX when running cmake, it 
> does not mention setting DESTDIR when invoking make install.
> If you don't set the DESTDIR on make install it will honour the 
> CMAKE_INSTALL_PREFIX for some parts of the installation (e.g. header files, 
> native libraries, pkg-config file etc) but the python bindings (and I assume 
> other bindings) will still install in the standard location which will fail 
> if you are not running as root.
> However if you set DESTDIR then this alters the location of the headers, 
> libraries and pkg-config , which now install into 
> $DESTDIR/$CMAKE_INSTALL_PREFIX and the pkg-config file no longer has the 
> correct include or library paths in it. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to