Hi Keith - sorry about the breakage... ----- Original Message ----- > From: "Keith Wall (JIRA)" <j...@apache.org> > To: proton@qpid.apache.org > Sent: Wednesday, December 4, 2013 4:24:36 AM > Subject: [jira] [Comment Edited] (PROTON-200) [Proton-c] Credit distribution > by messenger is not balanced across all > links > > > [ > > https://issues.apache.org/jira/browse/PROTON-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838760#comment-13838760 > ] > > Keith Wall edited comment on PROTON-200 at 12/4/13 9:23 AM: > ------------------------------------------------------------ > > Hi Ken, > > That commit (rev 1547534) uses JDK 7 specific features (specifically > java.net.StandardSocketOptions) so the build is now breaking. Please see > > https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/495/console > > Can we enable tcp no delay on the socket instead? >
I imagine so - I'll give it a try. > regards, Keith. > > btw. to which components does this Jira apply? The Jira title starts > [proton-c]..., but the assigned component is proton-j. > Yes, that is confusing. The JIRA actually applies to both proton-j and proton-c - I originally implemented it for proton-c (to prove the design), the latest checkin is the corresponding JAVA changes. I'll fix the build, test on a machine with an older Java rev, and update the jira. thanks, -K > > was (Author: k-wall): > Hi Ken, > > That commit (rev 1547534) uses JDK 7 specific features (specifically > java.net.StandardSocketOptions) so the build is now breaking. Please see > > https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/495/console > > Can we enable tcp no delay on the socket instead? > > regards, Keith. > > > [Proton-c] Credit distribution by messenger is not balanced across all > > links > > ---------------------------------------------------------------------------- > > > > Key: PROTON-200 > > URL: https://issues.apache.org/jira/browse/PROTON-200 > > Project: Qpid Proton > > Issue Type: Bug > > Components: proton-j > > Affects Versions: 0.3 > > Reporter: Ken Giusti > > Assignee: Ken Giusti > > Fix For: 0.6 > > > > Attachments: proton-200.patch, upstream-credit.patch > > > > > > The method used to distribute credit to receiving links may lead to > > starvation when the number of receiving links is > the available credit. > > The distribution algorithm always starts with the same link - see > > messenger.c::pn_messenger_flow() > > > > -- > This message was sent by Atlassian JIRA > (v6.1#6144) > -- -K
