[ 
https://issues.apache.org/jira/browse/PROTON-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182604#comment-14182604
 ] 

German Shepherd commented on PROTON-725:
----------------------------------------

Thanks for a response - you have a good point there.

To explain my situation:
the (cloud) Provisioning Service does not provide the escaped URL, but instead 
it gives me the values unescaped, and this is what I've directly fed to the 
pni_parse_url().

Fix is simple then - to modify our user code, and keep pni_parse_url() intact. 

But then - *will the ProtonC be able to unescape the URL ?* 
I'm not sure about it (I will try it, of course - but I have not seen any 
unescape() or such, in ProtonC code, after the URL gets parsed). 

At this moment, this issue will possibly happen only with "password" field, so 
it is more like a question for Azure, whether it will accept escaped password 
via SASL. I doubt that - I would say that SASL will want to see the very same 
'password' in the very same format, as it provided to us via Provisioning.

Hmm this will not be that easy after all...


> pni_parse_url does not properly handle Base64 in URL
> ----------------------------------------------------
>
>                 Key: PROTON-725
>                 URL: https://issues.apache.org/jira/browse/PROTON-725
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.8
>            Reporter: German Shepherd
>            Priority: Minor
>
> Our provisioning system provides us with a password in Base64 format, which 
> can actually contain a slash character(s): '/'
> This breaks the ability of {{pni_parse_url()}} to handle such URLs.
> Example of URL string on which the parsing fails:
> {{amqps://0ABCDEF1:/ExlxtfN+UxfExRxuwxIeFxeFzXLxxg+fxPx3x8xxU=@myself.servicebus.windows.net/out/txxxx/Subscriptions/syyyy}}
> Instead of filling up the "user" and "password" variables, it puts the actual 
> contents to "host" and "port". 
> With the actual code it is a correct behavior - and *it is* also mentioned in 
> the comment right in front of the pni_parse_url() function.
> Yet I would need an update to the functionality, to handle the Base64 in 
> password properly (anyone on Azure platform might run to this issue, soon or 
> later).
> Note. I'm running the SVN rev 1633464 (latest trunk of 10/23/2014) version of 
> ProtonC (C / Linux).
> Thanks for looking at this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to