[
https://issues.apache.org/jira/browse/PROTON-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301326#comment-14301326
]
Rafael H. Schloming commented on PROTON-811:
--------------------------------------------
Hi Adrian,
Thanks for reworking this. I tried applying this and ran into a few more
issues. Minor nitpick, I noticed after applying the patch that git diff shows
up extra whitespace in the files. We try not to have extraneous whitespace.
Your editor probably has a setting that will clean that sort of thing up for
you automatically. It might be worth looking into.
Beyond that, I had some trouble compiling. I think maybe your java version is
newer, because my compiler barfed on the diamond operator (<>) used in the
tests. I fixed that easily enough, but then there were a bunch of missing
imports. I'm not sure how this worked for you unless maybe you're compiling
against an older/alternate version of the code?
Once I added the missing imports, I noticed a few failures in the jython test
suite. FYI, there are a number of tests written in python that get run against
both the proton-c and proton-j implementations. These tests help us keep things
consistent between the two and give us better/shared coverage. There are a set
of shims in proton-j/src/main/resources that adapt between the Java and C APIs.
There's actually already test coverage for idle timeouts in the python test
suite, those tests currently just skip for the Java impl because those parts of
the shim raise the Skipped() exception. I attempted to enable those pieces of
the shim to give some better coverage, however this showed up a difference in
the APIs. The C API stores the idle timeout on the transport object, whereas
you have it in the Connection object. If we could resolve this difference then
it would be pretty straightforward to enable the portion of the shim that deals
with idle timeouts and get added test coverage from the python test suite.
> [PATCH] proton-j: no way to implement idle timeout of a connection
> ------------------------------------------------------------------
>
> Key: PROTON-811
> URL: https://issues.apache.org/jira/browse/PROTON-811
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: 0.8
> Reporter: Adrian Preston
> Attachments: 0001-idle_timeout.patch,
> 0001-proton-j-updates-for-idle-timeout-mk3.patch,
> 0001-proton-j-updates-for-idle-timeout.patch
>
>
> Proton-J does not provide access to idle timeout values and there appears to
> be no way to send a empty frame (as per section 2.4.5 of the AMQP 1.0
> standard)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
