[
https://issues.apache.org/jira/browse/PROTON-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591514#comment-14591514
]
Gordon Sim commented on PROTON-915:
-----------------------------------
The spec says: "Any data appearing beyond the protocol header MUST match the
version indicated by the protocol header" also "Note that if the server only
supports a single protocol version, it is consistent with the above rules for
the server to send its protocol header prior to receiving anything from the
client and to subsequently close the socket if the client’s protocol header
does not match the server’s."
So I would argue that the current behaviour does not violate the spec.
> Incompatible protocol header handled incorrectly
> ------------------------------------------------
>
> Key: PROTON-915
> URL: https://issues.apache.org/jira/browse/PROTON-915
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: 0.9, 0.9.1
> Reporter: Gordon Sim
> Assignee: Rafael H. Schloming
> Priority: Blocker
> Fix For: 0.10
>
> Attachments:
> 0001-PROTON-915-Send-correct-AMQP-header-upon-protocol-mi.patch
>
>
> The correct response is to send back a supported header[1] before closing the
> socket. This worked for 0.8 but is broker from 0.9 onwards, I believe by this
> commit:
> https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;a=commit;h=1b2be03c748ef5a57cf181f8373b9b6e8f8cfd22
> It means anything relying on proton-c for protocol header handling is not
> compliant with the spec.
> [1] section 2.2 of spec: "If the requested protocol version is not
> supported, the server MUST send a protocol header with a supported protocol
> version and then close the socket."
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
