Github user ted-ross commented on the pull request:
https://github.com/apache/qpid-proton/pull/39#issuecomment-118902728
I'd like to see this pull request move forward. On Dan's points above:
1) I agree with Andrew that using __LINE__ as an error code should be
changed to simply returning an eror code (or a null result, whichever is
appropriate).
2) I agree with Andrew here as well. I think it's an acceptable pattern to
check inputs and exit early if there is an error condition.
3) I agree with Dan that the library should simply report the failure to
allocate and not take any action on behalf of the process using it. There are
a number of cases where Proton makes relatively large allocations the failure
of which does not necessarily mean that the process can't recover.
Taking a piecemeal approach to cleaning up all the ignored allocations is
probably a good idea. If there are any API changes that will result, we should
try to get those all into a single release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
