[
https://issues.apache.org/jira/browse/PROTON-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616762#comment-14616762
]
ASF GitHub Bot commented on PROTON-936:
---------------------------------------
GitHub user gemmellr opened a pull request:
https://github.com/apache/qpid-proton/pull/42
PROTON-936 session outgoing window handling
As discussed on the mailing lists [1], proton currently sets the outgoing
window to 0 in most cases (except when using Messenger), but then sends
messages anyway if allowed by the current remote-outgoing-window. This means it
is typically violating the advertised window. Additionally, Service Bus uses
the outgoing window to initialise its incoming window, which means it is set to
0 and we can never send it any messages.
This is an initial attempt at an update based on the discussions. It sets
the outgoing window to a fixed default value of max int, and adds a setter to
allow users of the engine to adjust it. Mainly looking for feedback on the
approach and whether I have committed any atrocities on the C/python side, as I
basically cut and paste all of those changes after grep'ing use of other
fields/methods.
There is a basic test that the default exists and the getter+setter work,
but that is all as we dont actually use the [remote] outgoing window for
anything in proton currently so seems to be no way to inspect things.
[1]
http://mail-archives.apache.org/mod_mbox/qpid-users/201507.mbox/%3CCAFitrpQoK8SFgd1xXPtc9PeNWwWcEqtJgN8ZN88RBj3u6fwdag%40mail.gmail.com%3E
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gemmellr/qpid-proton PROTON-936_session_window
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit d7499a11b0aa6b73f85517c03fe2af18a50b77cc
Author: Robert Gemmell <[email protected]>
Date: 2015-07-07T10:17:58Z
PROTON-936: make session outgoing window size configurable, default to max
int
commit 808e99c865df6d94b15d3b9e78223bd46cd95e04
Author: Robert Gemmell <[email protected]>
Date: 2015-07-07T11:00:14Z
PROTON-936: initial c&p attempt at adding configurable session outgoing
window to proton-c
commit 33d69fc6a14948fbfcd46e080ffc0bd878e44bc4
Author: Robert Gemmell <[email protected]>
Date: 2015-07-07T13:02:23Z
PROTON-936: add a basic python test of the get/set methods
----
> update session outgoing window handling
> ---------------------------------------
>
> Key: PROTON-936
> URL: https://issues.apache.org/jira/browse/PROTON-936
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c, proton-j
> Affects Versions: 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.9.1
> Reporter: Robbie Gemmell
> Priority: Critical
> Fix For: 0.10
>
>
> As discussed on the mailing lists \[1\], proton currently sets the outgoing
> window to 0 in most cases (except when using Messenger), but then sends
> messages anyway if allowed by the current remote-outgoing-window. This means
> it is typically violating the advertised window. Additionall, Service Bus
> uses the outgoing window to initialise its incoming window, which means it is
> set to 0 and we can never send it any messages.
> We should update the outgoing window to address these issues.
> \[1\]
> http://mail-archives.apache.org/mod_mbox/qpid-users/201507.mbox/%3CCAFitrpQoK8SFgd1xXPtc9PeNWwWcEqtJgN8ZN88RBj3u6fwdag%40mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
