Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/45#issuecomment-120519490
I've committed these changes now, I did fix them up a bit:
Specifically:
- I changed the logic in pn_data_add() to use early return too - I must
have missed that in my review.
- I coalesced a couple of declarations with first use.
- I removed a now unecessary code block
- I removed the error checking from uses of pn_data_enter/exit as these
don't return an error code at all. Rather the returned boolean has meaning as
defined in the documentation. In the use here it can never return false.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
