Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/48#discussion_r36174549
  
    --- Diff: 
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
    @@ -217,6 +101,19 @@ public void dispatch(Handler handler)
                 dispatch(children.next());
             }
         }
    +    
    +    @Override
    +    public void redispatch(EventType as_type, Handler handler) throws 
HandlerException 
    --- End diff --
    
    A little unclear why this is needed, but ignoring that...it seems like 
using it inside a handler (as in the test) would lead to 'redispatch' to the 
current and child handlers before the original event is then subsequently given 
to any child handlers. Expected? Worth documenting?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to