Github user bozzzzo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36179971
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java ---
@@ -57,9 +58,13 @@ public void pop()
}
}
- public EventImpl put(Event.Type type, Object context)
+ public EventImpl put(EventType type, Object context)
{
- if (tail != null && tail.getType() == type &&
+ if (type == null)
+ throw new IllegalArgumentException("Type cannot be null");
+ if (!type.isValid())
+ throw new IllegalArgumentException("Cannot put events of type
" + type);
+ if (tail != null && tail.getEventType() == type &&
--- End diff --
Frankly, I'm not even sure why this check is needed at all.
But extensibe events don't need to change collector semantics. the change
here is
a mostly about robustness and a bit about the fact that not only core
events are now possible.
If needed this should be a separate change with separate justification.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
