[
https://issues.apache.org/jira/browse/PROTON-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066802#comment-15066802
]
ASF GitHub Bot commented on PROTON-1082:
----------------------------------------
Github user gemmellr commented on the pull request:
https://github.com/apache/qpid-proton/pull/52#issuecomment-166376050
Hi Sreeram,
I have committed changes to implement support for both setting the local
properties to be sent to the peer and inspecting the remote properties conveyed
from the peer.
The local bit is fairly close to your changes, other than updating the
names for consistency the main change is that it adds type details to the Map
and restricts the keys to be Symbol values, since symbols are the only type of
key AMQP 1.0 spec permits in the case of the link properties.
Robbie
(Mentioning PROTON-1082 here so the bot updates it too, since it isn't in
the PR title)
> add ability to specify and inspect properties for link attach frames
> --------------------------------------------------------------------
>
> Key: PROTON-1082
> URL: https://issues.apache.org/jira/browse/PROTON-1082
> Project: Qpid Proton
> Issue Type: New Feature
> Components: proton-j
> Affects Versions: 0.12.0
> Environment: all
> Reporter: Sreeram Garlapati
> Assignee: Robbie Gemmell
> Labels: patch
> Fix For: 0.12.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is a feature request from windows azure eventhubs team. Here's the Pull
> request which has the required feature:
> https://github.com/apache/qpid-proton/pull/52
> I (sreeram, from windows azure eventHubs team) am starting to build eventHubs
> Java SDK and taking a dependency on proton-j (which will be available on
> GitHub, hopefully, soon). EventHubs amqp client will need to set
> AttachProperties to enable Critical scenarios for us.
> Currently, in the proton-j framework - all attach frame fields are exposed
> using the Link Interface. So, following the same pattern I added new Get/Set
> methods for setting AttachProperties.
> Couple of SSL tests which are completely unrelated to my pull request are
> failing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
