[
https://issues.apache.org/jira/browse/PROTON-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107119#comment-15107119
]
ASF GitHub Bot commented on PROTON-1096:
----------------------------------------
Github user gemmellr commented on the pull request:
https://github.com/apache/qpid-proton/pull/53#issuecomment-172938973
Hi Sreeram,
As you might have already seen from the JIRA update or commit just now, I
have made a further update here to go back to using an int to carry the 32bit
value for the message format. My change to use a long had caused some
compatibility issues that I don't think it is important enough a change to
warrant, so I've put it back to the int.
If you were just using an int (as your original PR would have needed), or
perhaps explicitly casting a long to int, then you shouldnt have to change
anything, but if you were now passing in a long directly after the earlier
changes you will need to make some updates too, in which case apologies for any
hassle caused.
Robbie
> [proton-j] enable set/get of MessageFormat on the Delivery being
> sent/received
> -------------------------------------------------------------------------------
>
> Key: PROTON-1096
> URL: https://issues.apache.org/jira/browse/PROTON-1096
> Project: Qpid Proton
> Issue Type: New Feature
> Components: proton-j
> Affects Versions: 0.12.0
> Reporter: Sreeram Garlapati
> Assignee: Robbie Gemmell
> Fix For: 0.12.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is a feature request from windows azure eventhubs team. Here's the pull
> request: https://github.com/apache/qpid-proton/pull/53
> I (sreeram, from windows azure eventHubs team) am building eventHubs Java
> client SDK and taking a dependency on proton-j (which will be available on
> GitHub, hopefully, soon) for Amqp.
> EventHubs amqp client will need to set a Custom MessageFormat to enable a
> Critical scenario for Sending (Send Batch) messages to EventHubs from our
> JavaClient.
> Delivery class, currently, already has a getMessageFormat().. I extended this
> to also have setMessageFormat() method which should be copied to the Transfer
> frame.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
