[
https://issues.apache.org/jira/browse/PROTON-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115402#comment-15115402
]
ASF subversion and git services commented on PROTON-1107:
---------------------------------------------------------
Commit 0845878ee03935f2097f89e147c88b9c68d3b3b2 in qpid-proton's branch
refs/heads/master from Robert Gemmell
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=0845878 ]
PROTON-1107: only create the attachments Record on a Delivery if it actually
gets used
> [proton-j] only create the attachments Record on a Delivery if it actually
> gets used
> ------------------------------------------------------------------------------------
>
> Key: PROTON-1107
> URL: https://issues.apache.org/jira/browse/PROTON-1107
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: 0.10, 0.11.0, 0.11.1
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.12.0
>
>
> We should only create the attachments Record on a Delivery if it actually
> gets used.
> When the Reactor bits were added in 0.10 via PROTON-881, all of the main
> engine objects were made to implement the 'Extendable' interface that gave
> them an 'attachments' 'Record' that can be used to store things, by default
> seemingly just details relating to the Handler heirarchy as used by the
> Reactor.
> In the case of the Delivery objects this currently means every message sent
> or received by the engine creates a RecordImpl object (which in turn holds a
> HashMap). This happens regardless of whether the Reactor is even being used,
> and whether there are any attachments being set/checked on the Delivery. Even
> when the Reactor is being used, by default the lowest level the Handlers seem
> to get looked up when process is called is at the Link level (then Session,
> then Connection, etc) meaning its likely the Delivery attachments will never
> be used unless by the application code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
